fapaul commented on pull request #18201: URL: https://github.com/apache/flink/pull/18201#issuecomment-1011932863
I had an internal discussion with @pnowojski and we think the best way is to remove this commit ae038db and add the new violation to the whitelist. You can do that by uncommenting this line [1] and running the ArchUnitTests [2] again locally. You also need to commit the file in the violations folder afterward. Please ensure that you have rebased your branch to the latest master **before** running the tests. [1] https://github.com/apache/flink/blob/06192741d02714499c6d0f671b21bfa2588a21bf/flink-architecture-tests/src/test/resources/archunit.properties#L26 [2] https://github.com/apache/flink/blob/master/flink-architecture-tests/src/test/java/org/apache/flink/architecture/ArchitectureTest.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
