[
https://issues.apache.org/jira/browse/FLINK-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394842#comment-15394842
]
ASF GitHub Bot commented on FLINK-4259:
---------------------------------------
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2299
The code change is very concise and looks right, the one issue that bugs me
is that there are no direct tests in place to verify it - and it is not
necessarily straight forward to test as it is a resource leak issue.
I tried building the project locally and in fact `PythonPlanBinderTest`
that uses the change transitively got stuck, but I could not manage to
reproduce the issue when running solely that test from IntelliJ.
I have fired up a travis test myself and the PR is also triggering one, let
us whether those go through.
@nssalian do you see a straight forward way to test the behaviour?
PS: Could you enabled the travis build on your repo, please? (As Flink
comes with a travis.yml all you need to do is to go to Travis, login with your
github user and hit enable on the repo.)
> Unclosed FSDataOutputStream in FileCache#copy()
> -----------------------------------------------
>
> Key: FLINK-4259
> URL: https://issues.apache.org/jira/browse/FLINK-4259
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Neelesh Srinivas Salian
> Priority: Minor
>
> {code}
> try {
> FSDataOutputStream lfsOutput = tFS.create(targetPath, false);
> FSDataInputStream fsInput = sFS.open(sourcePath);
> IOUtils.copyBytes(fsInput, lfsOutput);
> {code}
> The FSDataOutputStream lfsOutput should be closed upon exit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
