zentol commented on a change in pull request #18143:
URL: https://github.com/apache/flink/pull/18143#discussion_r783832227
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -599,20 +608,117 @@ public ExecutionGraph getExecutionGraph() {
@Override
public final void startScheduling() {
mainThreadExecutor.assertRunningInMainThread();
- registerJobMetrics(jobManagerJobMetricGroup, executionGraph,
this::getNumberOfRestarts);
+ registerJobMetrics(
+ jobManagerJobMetricGroup,
+ executionGraph,
+ this::getNumberOfRestarts,
+ ignored -> {},
+ executionGraph.getStatusTimestamp(JobStatus.INITIALIZING),
+ jobStatusMetricsSettings);
operatorCoordinatorHandler.startAllOperatorCoordinators();
startSchedulingInternal();
}
public static void registerJobMetrics(
Review comment:
I'm not too fond of it either, but returning something doesn't scale in
the long-term imo. What happens the next time we'd need to add a parameter that
isn't quite as nice as we'd like?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -599,20 +608,117 @@ public ExecutionGraph getExecutionGraph() {
@Override
public final void startScheduling() {
mainThreadExecutor.assertRunningInMainThread();
- registerJobMetrics(jobManagerJobMetricGroup, executionGraph,
this::getNumberOfRestarts);
+ registerJobMetrics(
+ jobManagerJobMetricGroup,
+ executionGraph,
+ this::getNumberOfRestarts,
+ ignored -> {},
Review comment:
it doesn't! will fix it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
