twalthr commented on a change in pull request #18342:
URL: https://github.com/apache/flink/pull/18342#discussion_r784000148
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeSerdeTest.java
##########
@@ -132,101 +130,35 @@
BigDecimal.valueOf(random.nextFloat()),
FACTORY.createSqlType(SqlTypeName.FLOAT)),
rexBuilder.makeExactLiteral(BigDecimal.valueOf(random.nextDouble())),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.YEAR, TimeUnit.YEAR,
SqlParserPos.ZERO)),
rexBuilder.makeIntervalLiteral(
BigDecimal.valueOf(100),
new SqlIntervalQualifier(
- TimeUnit.YEAR, TimeUnit.YEAR,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.YEAR, TimeUnit.MONTH,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.MONTH, TimeUnit.MONTH,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.MONTH, TimeUnit.MONTH,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.DAY,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.DAY,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.HOUR,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.HOUR,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.MINUTE,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.MINUTE,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.SECOND,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.DAY, TimeUnit.SECOND,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.HOUR, TimeUnit.HOUR,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.HOUR, TimeUnit.HOUR,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.HOUR, TimeUnit.MINUTE,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.HOUR, TimeUnit.MINUTE,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.HOUR, TimeUnit.SECOND,
SqlParserPos.ZERO)),
+ TimeUnit.YEAR,
+ 4,
+ TimeUnit.YEAR,
+ RelDataType.PRECISION_NOT_SPECIFIED,
+ SqlParserPos.ZERO)),
rexBuilder.makeIntervalLiteral(
BigDecimal.valueOf(3),
new SqlIntervalQualifier(
- TimeUnit.HOUR, TimeUnit.SECOND,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.MINUTE, TimeUnit.MINUTE,
SqlParserPos.ZERO)),
+ TimeUnit.YEAR,
+ 2,
+ TimeUnit.MONTH,
+ RelDataType.PRECISION_NOT_SPECIFIED,
+ SqlParserPos.ZERO)),
rexBuilder.makeIntervalLiteral(
BigDecimal.valueOf(3),
new SqlIntervalQualifier(
- TimeUnit.MINUTE, TimeUnit.MINUTE,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.MINUTE, TimeUnit.SECOND,
SqlParserPos.ZERO)),
+ TimeUnit.DAY, 2, TimeUnit.SECOND, 6,
SqlParserPos.ZERO)),
rexBuilder.makeIntervalLiteral(
BigDecimal.valueOf(3),
new SqlIntervalQualifier(
- TimeUnit.MINUTE, TimeUnit.SECOND,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- new SqlIntervalQualifier(
- TimeUnit.SECOND, TimeUnit.SECOND,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.SECOND, TimeUnit.SECOND,
SqlParserPos.ZERO)),
+ TimeUnit.SECOND, 2, TimeUnit.SECOND,
6, SqlParserPos.ZERO)),
rexBuilder.makeDateLiteral(DateString.fromDaysSinceEpoch(10)),
rexBuilder.makeDateLiteral(new
DateString("2000-12-12")),
rexBuilder.makeTimeLiteral(TimeString.fromMillisOfDay(1234), 3),
rexBuilder.makeTimeLiteral(TimeString.fromMillisOfDay(123456), 6),
rexBuilder.makeTimeLiteral(new
TimeString("01:01:01.000000001"), 9),
- rexBuilder.makeTimeWithLocalTimeZoneLiteral(
Review comment:
but time and not timestamp. I don't think that we will ever support time
LTZ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
