galenwarren commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-1012485195
@xintongsong Sounds great! Many thanks for all your work and guidance on this project. Once we get the CI issues resolved, I'll squash everything so it will be ready to merge. You mentioned before using an appropriate commit message, would something based on the initial description in the PR work, i.e. > This PR adds RecoverableWriter support for Google Storage (GS), to allow writing to GS buckets from Flink's StreamingFileSink. To do this, we implement and register a FileSystem implementation for GS and then provide a RecoverableWriter implementation via createRecoverableWriter. ... or were you thinking something more detailed. @zentol Thanks for your suggestions. I'm trying one other thing first -- when we first started this PR, the versions of Guava and some other dependencies in `flink-fs-hadoop-shaded` were older than what was required by some of the Google libraries we use; so, I had to exclude some dependencies in `flink-fs-hadoop-shaded` in favor of the Google-supplied ones. Since then, `flink-fs-hadoop-shaded` has been updated, and its versions seem fine. So I'm reversing things, excluding dependencies from `google-cloud-storage` and `gcs-connector` that are supplied by `flink-fs-hadoop-shaded`. This does seem to have reduced the number of different grpc versions in the dependency tree, and I'm curious if it will affect our CI issues. I'm waiting for the CI build to occur now. If this doesn't fix it, I'll follow through on your dependency-convergence suggestion. Last, I've excluded the ` org.checkerframework:checker-compat-qual`, ` org.checkerframework:checker-qual`, and `org.codehaus.mojo:animal-sniffer-annotations` libraries and removed their license files and entries in NOTICE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
