Myasuka commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r784683300
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange
keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 ->
t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
Thanks for your clarification, I think we can improve the comment, e.g
What the `ACK` is meaning here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
