dmvk commented on a change in pull request #18332:
URL: https://github.com/apache/flink/pull/18332#discussion_r784718698



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -1175,6 +1185,31 @@ private void terminateMiniClusterServices() throws 
Exception {
         }
     }
 
+    /**
+     * Prevent multiple submission of the same JobGraph that has been mutated 
in between

Review comment:
       I have to double check, I think this might actually also be the case for 
application / per-job mode, but that might be OK as the user isn't really 
exposed to this API.
   
   Even if that's true, I'd be OK with cloning a JobGraph here, it has actually 
been my first approach.
   
   Overall the best solution would be simply making the `JobGraph` immutable, 
but that's a bigger story :/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to