galenwarren commented on a change in pull request #15599:
URL: https://github.com/apache/flink/pull/15599#discussion_r784923465
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -159,20 +191,14 @@ under the License.
</relocations>
<filters>
- <filter>
-
<artifact>org.apache.flink:flink-fs-hadoop-shaded</artifact>
-
<excludes>
-
<!-- exclude Guava classes from flink-fs-hadoop-shaded that we replace -->
-
<exclude>com/google/common/**</exclude>
-
</excludes>
- </filter>
<filter>
<artifact>*</artifact>
<excludes>
<exclude>properties.dtd</exclude>
<exclude>PropertyList-1.0.dtd</exclude>
<exclude>mozilla/**</exclude>
<exclude>META-INF/maven/**</exclude>
+
<exclude>META-INF/versions/**</exclude>
Review comment:
In one of the configurations I tried, there was a warning of conflicting
versions of this file in the final jar. I'll check to see if it's still there
in the current configuration and will remove if not.
Looks like the build still failed, so I'll try your dependency-convergence
suggestion. I do have a question, though -- we already have a working solution
(see
[here](https://github.com/apache/flink/pull/15599#issuecomment-1006405358),
thanks to @rmetzger), but we didn't move forward with it because we didn't
understand why the problem only occurred in the Azure CI build and not
elsewhere. If going down the dependency-convergence yields another working
solution, will we have an answer (or a theory) on that question? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
