[
https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476563#comment-17476563
]
Jing Zhang commented on FLINK-25614:
------------------------------------
[~wenlong.lwl] [~lmagics] Sorry for late response.
I agree with [~wenlong.lwl] it's a bug.`LocalSlicingWindowAggOperator` forgets
to set ChainingStrategy.
[~lmagics] Would you like to take this issue?
> Maybe we should consult [~jark] & [~jingzhang] for details about the reason
> to use Long instead of TimestampData.
I'm not understanding why you refer to the long, it seems to be no relation
with this bug.
Am I missing something?
BTW, we use long to represent timestamp in the underlying operators, it's just
an improvement.
> Let LocalWindowAggregate be chained with upstream
> -------------------------------------------------
>
> Key: FLINK-25614
> URL: https://issues.apache.org/jira/browse/FLINK-25614
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Runtime
> Affects Versions: 1.14.2
> Reporter: Q Kang
> Priority: Minor
> Labels: pull-request-available
>
> When enabling two-phase aggregation (local-global) strategy for Window TVF,
> the physical plan is shown as follows:
> {code:java}
> TableSourceScan -> Calc -> WatermarkAssigner -> Calc
> ||
> || [FORWARD]
> ||
> LocalWindowAggregate
> ||
> || [HASH]
> ||
> GlobalWindowAggregate
> ||
> ||
> ...{code}
> We can let the `LocalWindowAggregate` node be chained with upstream operators
> in order to improve efficiency, just like the non-windowing counterpart
> `LocalGroupAggregate`.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
