twalthr commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r785818885
##########
File path: docs/layouts/shortcodes/query_state_warning.html
##########
@@ -16,5 +16,7 @@
specific language governing permissions and limitations
under the License.
*/}}
-For streaming queries the required state to compute the query result might
grow infinitely depending on the type of aggregation and the number of distinct
grouping keys. Please provide a query configuration with valid retention
interval to prevent excessive state size.
-See <a href="/docs/dev/table/streaming/query_configuration">Query
Configuration</a> for details.
+For streaming queries the required state to compute the query result might
grow infinitely depending
+on the type of aggregation and the number of distinct grouping keys. Please
provide a query
+configuration with valid retention interval to prevent excessive state size.
+See <a
href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/table/config/#idle-state-retention-time">Query
Configuration</a> for details.
Review comment:
This was part of an class called `Query Configuration`. Maybe update the
title as well.
##########
File path: docs/content.zh/release-notes/flink-1.10.md
##########
@@ -179,7 +179,7 @@ If you try to reuse your previous Flink configuration
without any adjustments,
the new memory model can result in differently computed memory parameters for
the JVM and, thus, performance changes.
-Please, check [the user documentation](../deployment/memory/mem_setup.html)
for more details.
+Please, check [the user
documentation](https://nightlies.apache.org/flink/flink-docs-release-1.10/ops/memory/mem_setup.html)
for more details.
Review comment:
why a hard link here? in case we should link to something stable and not
nightly?
##########
File path: docs/content/docs/dev/table/config.md
##########
@@ -98,6 +96,39 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+### Idle State Retention Time
Review comment:
This was put under the `Streaming Concepts` section before. I'm fine
with leaving it here. But we should make sure that this is for streaming only?
We also have a `State Management` section in Streaming Concepts Overview?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
