wangyang0918 commented on a change in pull request #17503:
URL: https://github.com/apache/flink/pull/17503#discussion_r786384894
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java
##########
@@ -96,6 +96,11 @@ public KubernetesJobManagerParameters(
.orElse(Collections.emptyList());
}
+ @Override
Review comment:
Why do we have this change?
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/InitJobManagerDecorator.java
##########
@@ -149,6 +150,7 @@ private Container decorateMainContainer(Container
container) {
.withNewFieldRef(API_VERSION,
POD_IP_FIELD_PATH)
.build())
.endEnv();
+ getFlinkLogDirEnv().ifPresent(mainContainerBuilder::addToEnv);
Review comment:
We need to add a unit test to guard this behavior.
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/InitTaskManagerDecorator.java
##########
@@ -144,6 +145,7 @@ private Container decorateMainContainer(Container
container) {
.withContainerPort(kubernetesTaskManagerParameters.getRPCPort())
.build())
.addAllToEnv(getCustomizedEnvs());
+ getFlinkLogDirEnv().ifPresent(mainContainerBuilder::addToEnv);
Review comment:
We need to add a unit test to guard this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
