tillrohrmann commented on a change in pull request #18194:
URL: https://github.com/apache/flink/pull/18194#discussion_r786542050



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -195,6 +195,8 @@ public Dispatcher(
         this.dispatcherBootstrapFactory = 
checkNotNull(dispatcherBootstrapFactory);
 
         this.recoveredJobs = new HashSet<>(recoveredJobs);
+        this.blobServer.retainJobs(

Review comment:
       Hmm, thinking again about it I think that the `ioExecutor` won't work. 
The problem is that we want to finish the cleanup before the `Dispatcher` 
starts. Otherwise, we risk that we remove jobs that were newly submitted. 
Hence, I will revert this change. I also think that it is not a problem to not 
run it in the `ioExecutor` because the `Dispatcher` is not running at this 
point in time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to