twalthr commented on a change in pull request #18287:
URL: https://github.com/apache/flink/pull/18287#discussion_r786612124
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala
##########
@@ -722,9 +722,9 @@ class ExprCodeGenerator(ctx: CodeGeneratorContext,
nullableInput: Boolean)
case ARRAY_VALUE_CONSTRUCTOR =>
generateArray(ctx, resultType, operands)
- // maps and multisets
- case MAP_VALUE_CONSTRUCTOR | MULTISET_VALUE =>
- generateMapOrMultiset(ctx, resultType, operands)
+ // maps
+ case MAP_VALUE_CONSTRUCTOR =>
Review comment:
@snuyanzin Looking forward to a PR for this commit. Maybe you can also
address the comment about the value constructor in this PR (using HashMap for
deduplication of key).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
