spoon-lz commented on a change in pull request #18119:
URL: https://github.com/apache/flink/pull/18119#discussion_r786715304
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -240,20 +238,11 @@ private String getWebMonitorAddress(Configuration
configuration) throws Exceptio
flinkConfig.setString(KubernetesConfigOptionsInternal.ENTRY_POINT_CLASS,
entryPoint);
- // Rpc, blob, rest, taskManagerRpc ports need to be exposed, so update
them to fixed values.
- KubernetesUtils.checkAndUpdatePortConfigOption(
- flinkConfig, BlobServerOptions.PORT,
Constants.BLOB_SERVER_PORT);
- KubernetesUtils.checkAndUpdatePortConfigOption(
- flinkConfig, TaskManagerOptions.RPC_PORT,
Constants.TASK_MANAGER_RPC_PORT);
- KubernetesUtils.checkAndUpdatePortConfigOption(
- flinkConfig, RestOptions.BIND_PORT, Constants.REST_PORT);
+ KubernetesUtils.updatePorts(flinkConfig);
Review comment:
The code seems to be organized and tested on a real k8s cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
