rkhachatryan commented on a change in pull request #18391:
URL: https://github.com/apache/flink/pull/18391#discussion_r786880573
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/SharedStateRegistryTest.java
##########
@@ -98,6 +106,77 @@ public void testUnregisterWithUnexistedKey() {
sharedStateRegistry.unregisterUnusedState(Long.MAX_VALUE);
}
+ @Test
+ public void testRegisterChangelogStateBackendHandles() throws
InterruptedException {
+ SharedStateRegistry sharedStateRegistry = new
SharedStateRegistryImpl();
+ long materializationId1 = 1L;
+ IncrementalStateHandleWrapper incrementalTMStateHandle1 =
+ createDummyIncrementalStateHandle(materializationId1);
+
+ IncrementalStateHandleWrapper incrementalJMStateHandle11 =
incrementalTMStateHandle1.copy();
Review comment:
NIT: To me, handle names aren't very informative and readable.
While reviewing, I renamed them to:
`materializedStateBase`
`materializedState1`
`nonMaterializedState1`
`backendState1`
etc.
So that they are shorter and convey information.
WDYT about such names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
