ruanhang1993 commented on a change in pull request #17601:
URL: https://github.com/apache/flink/pull/17601#discussion_r787338430
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java
##########
@@ -679,106 +729,165 @@ private void verifyEncoderSubject(
@Test
public void testSourceTableWithTopicAndTopicPattern() {
- thrown.expect(ValidationException.class);
- thrown.expect(
- containsCause(
- new ValidationException(
- "Option 'topic' and 'topic-pattern' shouldn't
be set together.")));
-
- final Map<String, String> modifiedOptions =
- getModifiedOptions(
- getBasicSourceOptions(),
- options -> {
- options.put("topic", TOPICS);
- options.put("topic-pattern", TOPIC_REGEX);
- });
-
- createTableSource(SCHEMA, modifiedOptions);
+ assertThatThrownBy(
+ () -> {
+ final Map<String, String> modifiedOptions =
+ getModifiedOptions(
+ getBasicSourceOptions(),
+ options -> {
+ options.put("topic", TOPICS);
+ options.put("topic-pattern",
TOPIC_REGEX);
+ });
+
+ createTableSource(SCHEMA, modifiedOptions);
+ })
+ .isInstanceOf(ValidationException.class)
+ .satisfies(
+ throwable ->
+ assertThatChainOfCauses(throwable)
+ .anySatisfy(
+ cause ->
+ assertThat(cause)
+ .isInstanceOf(
+
ValidationException.class)
+ .hasMessage(
+
"Option 'topic' and 'topic-pattern' shouldn't be set together.")));
Review comment:
`FlinkAssertions.anyCauseMatches()` uses `hasMessageContaining` to check
the error message. We need to check with `hasMessage` here.
I will add a new method `containsCause` to `FlinkAssertions` to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
