GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/2306

    [FLINK-4270] [table] fix 'as' in front of join does not work

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    
    
    The `Project` has a wrong way to construct RelNode. It pushes a new 
`LogicalProject` to the stack, but not pop the previous RelNode. It has problem 
when Join two tables. 
    
    When join two tables (with all fields renamed), the stack will look like 
this before join:
    
    ```
    LogicalProject1
    TableScan1
    LogicalProject0
    TableScan0
    ``` 
    
    After that, join will use  `LogicalProject1` and `TableScan1` which are the 
same table to create `LogicalJoin`. Then the exception throws.
    
    The correct way to do this is make sure the previous TableScan removed from 
the stack before we push a new LogicalProject. 
    
    ```
    LogicalProject1
    LogicalProject0
    ``` 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink FLINK-4270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2306
    
----
commit 20412c044103158dabd3de1f7a056018231f9275
Author: Jark Wu <[email protected]>
Date:   2016-07-28T09:33:53Z

    [FLINK-4270] [table] fix 'as' in front of join does not work

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to