LadyForest commented on a change in pull request #18394:
URL: https://github.com/apache/flink/pull/18394#discussion_r787401902
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -145,6 +145,19 @@ under the License.
<scope>test</scope>
<type>test-jar</type>
</dependency>
+ <dependency>
Review comment:
`TestManagedFactory` can be removed from
`org.apache.flink.table.factories.Factory` file under the `table-planner`
module to avoid adding a test-jar dependency. But `flink-orc` and
`flink-parquet` cannot eliminate `guava` test dependency, o.w. there will be a
`NoClassDefFoundError` thrown (this transitive dependency is introduced by
Calcite)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
