[
https://issues.apache.org/jira/browse/FLINK-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398744#comment-15398744
]
ASF GitHub Bot commented on FLINK-4269:
---------------------------------------
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2307
Hi @aditivin , welcome to the community. Thank you for the PR as well.
A few suggestions:
1) Upon opening a PR, it is best to add more information regarding testing
or even checks that you have done.
I believe the PR template helps add more information with regards to
testing /checks.
2) I don't see much testing that can be done here, anything you see that
can help testing the debug logging, @aditivin?
3) One additional point would be to enable the travis build on your
repository.
(As Flink comes with a travis.yml all you need to do is to go to Travis,
login with your github user and hit enable on the repo.) A local build helps
understand if there are issues that could occur.
This link should be helpful:
https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo
> Decrease log level in RuntimeMonitorHandler
> -------------------------------------------
>
> Key: FLINK-4269
> URL: https://issues.apache.org/jira/browse/FLINK-4269
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Affects Versions: 1.1.0
> Reporter: Ufuk Celebi
> Priority: Minor
>
> Having a browser window open which points to a page of an unavailable job
> (for example from a previous cluster setup) leads to many log warning
> messages like this in the job manager log file:
> {code}
> 2016-06-30 10:50:55,812 WARN
> org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler - Error while
> handling request
> org.apache.flink.runtime.webmonitor.NotFoundException: Could not find job
> with id 343bd3c0c7415370d79e04f305b5a2e9
> at
> org.apache.flink.runtime.webmonitor.handlers.AbstractExecutionGraphRequestHandler.handleRequest(AbstractExecutionGraphRequestHandler.java:58)
> at
> org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler.respondAsLeader(RuntimeMonitorHandler.java:135)
> at
> org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler.channelRead0(RuntimeMonitorHandler.java:112)
> at
> org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler.channelRead0(RuntimeMonitorHandler.java:60)
> at
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:339)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:324)
> at io.netty.handler.codec.http.router.Handler.routed(Handler.java:62)
> at
> io.netty.handler.codec.http.router.DualAbstractHandler.channelRead0(DualAbstractHandler.java:57)
> at
> io.netty.handler.codec.http.router.DualAbstractHandler.channelRead0(DualAbstractHandler.java:20)
> at
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:339)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:324)
> at
> org.apache.flink.runtime.webmonitor.HttpRequestHandler.channelRead0(HttpRequestHandler.java:104)
> at
> org.apache.flink.runtime.webmonitor.HttpRequestHandler.channelRead0(HttpRequestHandler.java:65)
> at
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:339)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:324)
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:242)
> at
> io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:147)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:339)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:324)
> at
> io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:847)
> at
> io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
> at
> io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)
> at
> io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
> at
> io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111)
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)
> {code}
> Since the REST API calls are refreshed every X seconds, this can lead to
> quite some log pollution. We might consider decreasing the log level to DEBUG
> or TRACE even.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
