lindong28 edited a comment on pull request #56:
URL: https://github.com/apache/flink-ml/pull/56#issuecomment-1017123440


   Thanks for the PR.
   
   Before we continue to add more and more algorithm, what's our plan to make 
sure these algorithm's implementation could meet our performance target? I am 
concerned that if we add more algorithms before we have a benchmark plan, we 
might end up refactoring added algorithms in a unnecessary manner, which is 
probably not a good long term solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to