igalshilman commented on a change in pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#discussion_r788618532
##########
File path:
statefun-flink/statefun-flink-harness/src/main/java/org/apache/flink/statefun/flink/harness/Harness.java
##########
@@ -126,6 +129,14 @@ public Harness withSavepointLocation(String
savepointLocation) {
}
public void start() throws Exception {
+ try {
+ startAsync().getJobExecutionResult().get();
+ } catch (ExecutionException ee) {
+
ExceptionUtils.rethrowException(ExceptionUtils.stripExecutionException(ee));
+ }
+ }
+
+ public JobClient startAsync() throws Exception {
Review comment:
I'm not sure that I'd like to expose the `JobClient` as a public method
on the `Harness`.
How about we think about it as a followup PR?
##########
File path:
statefun-e2e-tests/statefun-smoke-e2e-embedded/src/test/java/org/apache/flink/statefun/e2e/smoke/embedded/EmbeddedSmokeHarnessMigrationTest.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.statefun.e2e.smoke.embedded;
+
+import static
org.apache.flink.statefun.e2e.smoke.SmokeRunner.awaitVerificationSuccess;
+
+import java.io.File;
+import java.net.URI;
+import java.util.Arrays;
+import java.util.Collection;
+import org.apache.commons.io.FileUtils;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.statefun.e2e.smoke.SimpleVerificationServer;
+import org.apache.flink.statefun.e2e.smoke.SmokeRunnerParameters;
+import org.apache.flink.statefun.flink.harness.Harness;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@RunWith(Parameterized.class)
+public class EmbeddedSmokeHarnessMigrationTest {
Review comment:
Thanks for adding a migration test!
This test would catch any internal migration issues with the core statefun
job graph.
Perhaps we need to followup with a separate e2e migration test, that runs
within its own migration profile, that includes at least a Kafka ingress/egress
pair.
It can be completely based remote functions, without any
verification/failure injection aspects to it, and this probably should be based
on `testcontainers` instead of the harness.
having test containers will allows the test to create a save point in an
arbitrary previous version (say 3.1.1)
based on the previously released official docker images, and load it with
the current version.
The test would be bit more time consuming, and that's why I would recommend
that to run under a different profile.
If this is something you find reasonable, then I'll create a followup JIRA
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
