tillrohrmann edited a comment on pull request #18419: URL: https://github.com/apache/flink/pull/18419#issuecomment-1017402694
Thanks for the review @zentol. I've addressed your comments. I also had to add another fixup commit in order to add the shutdown hook to the `TaskManagerRunner`. The problem was that we initialized several services in the constructor where we also registered the shut down hook. This could then lead to the situation that either the shutdown hook wasn't registered when `SIGTERM` came or that the initialization and the shutdown logic was running concurrently. In order to fix this up, I have moved the service initialization out of the constructor into a method that is called by the `start` method. The alternative would have been to run the constructor under the `lock` which seemed a bit weird because also then it was important to register the shutdown hook before any resource was created. Otherwise we might miss the signal and keep resources around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
