dannycranmer commented on a change in pull request #18348:
URL: https://github.com/apache/flink/pull/18348#discussion_r788677549
##########
File path: docs/content/docs/connectors/table/kinesis.md
##########
@@ -733,12 +799,23 @@ In the event that a job terminates within executing the
shutdown hooks, stream c
In this situation the stream consumers will be gracefully reused when the
application restarts.
With the `NONE` and `EAGER` strategies, stream consumer de-registration is not
performed by `FlinkKinesisConsumer`.
-Data Type Mapping
-----------------
+# Data Type Mapping
+
Kinesis stores records as Base64-encoded binary data objects, so it doesn't
have a notion of internal record structure.
Instead, Kinesis records are deserialized and serialized by formats, e.g.
'avro', 'csv', or 'json'.
To determine the data type of the messages in your Kinesis-backed tables, pick
a suitable Flink format with the `format` keyword.
Please refer to the [Formats]({{< ref "docs/connectors/table/formats/overview"
>}}) pages for more details.
+# Updates in 1.15
Review comment:
Can we call out that the new sink does not support aggregation? This is
the biggest gap
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/pom.xml
##########
@@ -82,6 +82,13 @@ under the License.
<version>${aws.sdk.version}</version>
Review comment:
Please link the follow up Jira or PR
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/table/KinesisConnectorOptions.java
##########
@@ -64,7 +65,7 @@
"fixed (each Flink
partition ends up in at most one Kinesis shard)"),
text(
"custom class name (use a
custom %s subclass)",
-
text(KinesisPartitioner.class.getName())))
+
text(PartitionKeyGenerator.class.getName())))
Review comment:
Please link Jira or PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
