imaffe commented on a change in pull request #18406:
URL: https://github.com/apache/flink/pull/18406#discussion_r789012670
##########
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java
##########
@@ -265,6 +266,15 @@
return this;
}
+ /**
+ * If you enable this option, we would consume and deserialize the message
by using Pulsar
+ * {@link Schema}.
+ */
+ public PulsarSourceBuilder<OUT> enableSchemaEvolution() {
+ configuration.set(PULSAR_ENABLE_SCHEMA_EVOLUTION, true);
Review comment:
I think the evolution should not be decided by connector, instead it
should be decided by the broker configuration. The reason is , most of the
cases whether the evolution should be enabled is coupled with the broker
configuration, . Adding configuration in the source connector could happen the
following
1. Connector enabled evolution, but broker disabled
2. Connector disabled evolution , but broker enabled (and user might expect
the connector to support evolution automatically)
So I feel like the source connector schema evolution should not be
configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
