MartijnVisser commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789377665



##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where 
the first window aggreg
 ```sql
 -- tumbling 5 minutes for each supplier_id
 CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as 
partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time 
as rowtime, SUM(price) as partial_price

Review comment:
       I see. If that's the case, then I guess we should indeed update this 
documentation :) I would then only slightly modify the alias to make it more 
clearer, something like: 
   
   ```suggestion
   SELECT window_start as window_5mintumble_start, window_end as 
window_5mintumble_end, window_time as rowtime, SUM(price) as partial_price
   ```
   or
   
   ```suggestion
   SELECT window_start as window_5mintumblepersupplier_start, window_end as 
window_5mintumblepersupplier_end, window_time as rowtime, SUM(price) as 
partial_price
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to