JingsongLi commented on a change in pull request #18394:
URL: https://github.com/apache/flink/pull/18394#discussion_r789416976
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SourceQueryOperation.java
##########
@@ -72,4 +85,8 @@ public String asSummaryString() {
public <T> T accept(QueryOperationVisitor<T> visitor) {
return visitor.visit(this);
}
+
+ public Map<String, String> getDynamicOptions() {
Review comment:
Add @Nullable
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlToOperationConverterTest.java
##########
@@ -137,12 +140,12 @@
catalogManager.getCurrentDatabase());
private final PlannerContext plannerContext =
new PlannerContext(
- false,
Review comment:
Just modify this is OK
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SourceQueryOperation.java
##########
@@ -39,9 +41,17 @@
public class SourceQueryOperation implements QueryOperation {
private final ContextResolvedTable contextResolvedTable;
+ private final Map<String, String> dynamicOptions;
Review comment:
Add @Nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
