zentol commented on a change in pull request #18416:
URL: https://github.com/apache/flink/pull/18416#discussion_r789479364
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrap.java
##########
@@ -266,10 +271,22 @@ private void runApplicationEntryPoint(
final Set<JobID> tolerateMissingResult,
final DispatcherGateway dispatcherGateway,
final ScheduledExecutor scheduledExecutor,
- final boolean enforceSingleJobExecution) {
+ final boolean enforceSingleJobExecution,
+ final boolean submitFailedJobOnApplicationError) {
+ if (submitFailedJobOnApplicationError && !enforceSingleJobExecution) {
+ dispatcherGateway.submitFailedJob(
+ ZERO_JOB_ID,
+ FAILED_JOB_NAME,
+ new IllegalStateException(
+ String.format(
+ "Submission of failed job in case of an
application error ('%s') is not supported in non-HA setups.",
Review comment:
> If the exception happens between first and second submission (first
one has already completed). What job id do we submit the job with?
If the job had run the job ID would be random as well, right? Couldn't we
use that then?
> using ZERO_JOB_ID might not be correct
We should try to reduce this usage as much as possible, because it is quite
problematic (e.g., it breaks archiving).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
