Zarathustra2 opened a new pull request #18451:
URL: https://github.com/apache/flink/pull/18451
## What is the purpose of the change
Prevent usage of EventTimeWindows when EventTime is disabled. For instance:
```java
source.assignTimestampsAndWatermarks(WatermarkStrategy.noWatermarks())
.keyBy(t -> t.f1)
.window(SlidingEventTimeWindows.of(Time.milliseconds(1), Time.milliseconds(10)))
.process(...)
.print();
```
Would never window any inputs as the preceding watermark generator does not
emit watermarks.
This PR introduces a runtime check which throws an exception on startup if
any event time window has an invalid immediate preceding event time generator.
## Brief change log
- *Check for any event time window that it does not have an invalid (for
instance, noWatermark()) preceding event time generator*
## Verifying this change
This change added tests and can be verified as follows:
- *Added integration tests that asserts that an exception is thrown if an
event time window has an invalid preceding watermark generator*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
