Myasuka commented on a change in pull request #18157:
URL: https://github.com/apache/flink/pull/18157#discussion_r790401088
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointMetadataOutputStream.java
##########
@@ -162,4 +161,20 @@ public FsCompletedCheckpointStorageLocation
closeAndFinalizeCheckpoint() throws
}
}
}
+
+ static MetadataOutputStreamWrapper getOutputStreamWrapper(
+ final FileSystem fileSystem, final Path metadataFilePath) throws
IOException {
+ try {
+ RecoverableWriter recoverableWriter =
fileSystem.createRecoverableWriter();
+ if (fileSystem.exists(metadataFilePath)) {
+ throw new IOException("Target file " + metadataFilePath + " is
already exists.");
Review comment:
I think we should try to verify the file whether existed first.
Moreover, the statement `"Target file " + metadataFilePath + " already
exists."` looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
