wsry commented on a change in pull request #18130:
URL: https://github.com/apache/flink/pull/18130#discussion_r790564461
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
##########
@@ -834,14 +817,82 @@ public void testUpdateUnknownInputChannel() throws
Exception {
localResultPartitionId.getPartitionId(),
localLocation));
assertThat(
-
inputGate.getInputChannels().get(remoteResultPartitionId.getPartitionId()),
+ inputGate
+ .getInputChannels()
+
.get(createSubpartitionInfo(remoteResultPartitionId.getPartitionId())),
is(instanceOf((RemoteInputChannel.class))));
assertThat(
-
inputGate.getInputChannels().get(localResultPartitionId.getPartitionId()),
+ inputGate
+ .getInputChannels()
+
.get(createSubpartitionInfo(localResultPartitionId.getPartitionId())),
is(instanceOf((LocalInputChannel.class))));
}
}
+ @Test
+ public void testUpdateUnknownChannelWithSubpartitionIndexRange()
Review comment:
Maybe it's better to also cover the partition request with subpartition
range scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
