MartijnVisser commented on a change in pull request #18353:
URL: https://github.com/apache/flink/pull/18353#discussion_r790740403
##########
File path: docs/content/docs/connectors/datastream/cassandra.md
##########
@@ -37,7 +37,7 @@ To use this connector, add the following dependency to your
project:
{{< artifact flink-connector-cassandra withScalaVersion >}}
-Note that the streaming connectors are currently __NOT__ part of the binary
distribution. See how to link with them for cluster execution [here]({{< ref
"docs/dev/datastream/project-configuration" >}}).
+Note that the streaming connectors are currently __NOT__ part of the binary
distribution. See how to link with them for cluster execution [here]({{< ref
"docs/dev/configuration" >}}).
Review comment:
NB: All these links currently send me to
http://localhost:1313/flink/flink-docs-master/docs/dev/configuration/. That
page is blank, it should be
http://localhost:1313/flink/flink-docs-master/docs/dev/configuration/overview/
I think. So:
```suggestion
Note that the streaming connectors are currently __NOT__ part of the binary
distribution. See how to link with them for cluster execution [here]({{< ref
"docs/dev/configuration/overview" >}}).
```
##########
File path: docs/content/docs/dev/configuration/maven.md
##########
@@ -0,0 +1,106 @@
+---
Review comment:
I'm leaning towards moving the content of Maven, Gradle and SBT all to
sections under the Overview. Reasons for that is that if something changes on
the Project Configuration, you can immediately change it in one go and keep
things in sync. Probably with the tabs option to see different setups (a tab
for a Maven example, tab for Gradle etc). Something like that?
What made you think about splitting them to separate pages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
