pnowojski commented on a change in pull request #18392:
URL: https://github.com/apache/flink/pull/18392#discussion_r790759483
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/NettyShuffleMetricFactory.java
##########
@@ -223,4 +230,26 @@ public static void registerDebloatingTaskMetrics(
taskGroup.gauge(
MetricNames.ESTIMATED_TIME_TO_CONSUME_BUFFERS, new
TimeToConsumeGauge(inputGates));
}
+
+ /**
+ * This is a small hack. Instead of spawning a custom thread to monitor
{@link
+ * NetworkBufferPool} usage, we are re-using {@link View#update()} method
for this purpose.
+ */
+ private static class RequestedMemoryUsageMetric implements Gauge<Integer>,
View {
Review comment:
As I explained above this is not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
