galenwarren commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790798748
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+
<!-- exclude javax.annotation because of GPLv2 license, see
https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+
<exclude>javax/annotation/**</exclude>
Review comment:
Yes, the dependency is already excluded in that manner,
[here](https://github.com/apache/flink/blob/4050cf320fc6c3ad77ad406689dd8a99af75d594/flink-filesystems/flink-gs-fs-hadoop/pom.xml#L89).
And for Java 8 builds, that is sufficient -- there is no licensing problem.
In Java 11 builds, those two `package.html` files still seem to be present
and causing problems, somehow. Adding the filter is an attempt to remove them
from the jar file in those builds. In a local build of the Java 11 jar file,
with this configuration, I can confirm by inspection that no file from
`javax.annotation` -- including the `package.html` files -- is present. I don't
know how to run the license check locally, though, so I can't test whether this
fixes the Java 11 issue or not, without having someone merge the code.
I'm certainly open to alternate suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
