syhily commented on a change in pull request #17452:
URL: https://github.com/apache/flink/pull/17452#discussion_r791420346
##########
File path: flink-connectors/flink-connector-pulsar/pom.xml
##########
@@ -138,23 +140,60 @@ under the License.
<version>${pulsar.version}</version>
<scope>test</scope>
</dependency>
+
<!-- Pulsar use a newer commons-lang3 in broker. -->
<!-- Bump the version only for testing. -->
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
- <version>${commons-lang3.version}</version>
+ <version>${pulsar-commons-lang3.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- Pulsar use a newer zookeeper in broker. -->
+ <!-- Bump the version only for testing. -->
+ <dependency>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>zookeeper</artifactId>
+ <version>${pulsar-zookeeper.version}</version>
<scope>test</scope>
</dependency>
<!-- Add Pulsar 2.x as a dependency. -->
<!-- Move this to button for avoiding class conflicts with
pulsar-broker. -->
-
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-all</artifactId>
<version>${pulsar.version}</version>
<exclusions>
+ <exclusion>
+ <groupId>com.sun.activation</groupId>
Review comment:
These dependencies are just used for annotation which should be working
on the broker side. It's not required on the client side.
##########
File path: flink-connectors/flink-connector-pulsar/pom.xml
##########
@@ -163,13 +202,22 @@ under the License.
</dependency>
</dependencies>
- <!-- gRPC use version range which don't support by flink ci. -->
<dependencyManagement>
<dependencies>
+ <!-- Pulsar use higher gRPC version. -->
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-bom</artifactId>
- <version>${grpc.version}</version>
+ <version>${pulsar-grpc.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
Review comment:
Yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
