Github user vijikarthi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2275#discussion_r73023816
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
 ---
    @@ -81,13 +90,21 @@ public static void prepare() throws IOException, 
ClassNotFoundException {
                
LOG.info("-------------------------------------------------------------------------");
                LOG.info("    Starting KafkaTestBase ");
                
LOG.info("-------------------------------------------------------------------------");
    -           
     
    +           Configuration flinkConfig = new Configuration();
     
                // dynamically load the implementation for the test
                Class<?> clazz = 
Class.forName("org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl");
                kafkaServer = (KafkaTestEnvironment) 
InstantiationUtil.instantiate(clazz);
     
    +           LOG.info("Runtype: {}", RunTypeHolder.get());
    +           if(RunTypeHolder.get().equals(RunTypeHolder.RunType.SECURE)
    --- End diff --
    
    Yes == is more appropriate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to