tillrohrmann commented on a change in pull request #17485:
URL: https://github.com/apache/flink/pull/17485#discussion_r791731554
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesHighAvailabilityRecoverFromSavepointITCase.java
##########
@@ -141,20 +130,8 @@ public void testRecoverFromSavepoint() throws Exception {
jobGraphWithSavepoint.setSavepointRestoreSettings(
SavepointRestoreSettings.forPath(savepoint2Path));
clusterClient.submitJob(jobGraphWithSavepoint).get(TIMEOUT,
TimeUnit.MILLISECONDS);
- CommonTestUtils.waitUntilCondition(
- () -> clusterClient.getJobStatus(jobId).get() ==
JobStatus.RUNNING,
- Deadline.fromNow(Duration.ofMillis(TIMEOUT)),
- 1000);
- // The savepoint 2 should be added to jobmanager leader ConfigMap
- final String jobManagerConfigMapName = CLUSTER_ID + "-" + jobId +
"-jobmanager-leader";
- final Optional<KubernetesConfigMap> optional =
- flinkKubeClient.getConfigMap(jobManagerConfigMapName);
- assertThat(optional.isPresent(), is(true));
- final String checkpointIdKey =
- KubernetesCheckpointStoreUtil.INSTANCE.checkpointIDToName(2L);
- assertThat(optional.get().getData().get(checkpointIdKey),
is(notNullValue()));
-
assertThat(optional.get().getData().get(Constants.CHECKPOINT_COUNTER_KEY),
is("3"));
+
assertThat(clusterClient.requestJobResult(jobId).join().isSuccess()).isTrue();
Review comment:
I'll try to do this once all the fixup commits are squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
