wangyang0918 commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1020753728
@XComp > But I don't understand you claim that it make sense to have the REST suffix included in KubernetesLabel. I cannot even find a place where we use the clusterId + -rest as a label key or value. `clusterId` + `-rest` is not a label, but the service name. Currently, I know the label key/value and service name both have the 63 characters limitation. > Why do we have such an odd value (i.e. 45) for MAXIMUM_CHARACTERS_OF_CLUSTER_ID in the first place. Shouldn't it be 63 then? As a consequence, that would mean that we only have to have a single accessor for KubernetesConfigOptions.CLUSTER_ID that checks whether the specified clusterId is 63 characters or less, wouldn't it? Just like the rest service name(`clusterId` + `-rest`), we still have other resources need to check. Right? The reason why set the `MAXIMUM_CHARACTERS_OF_CLUSTER_ID` to 45, not 58(63 - 5`-rest`) is trying to leave some potential spaces for the future introduced service/labels. > Are there references to where the labels (i.e. the resources limited to 63 characters) are set? https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
