XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r792153225
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java
##########
@@ -52,22 +69,70 @@ public DispatcherLeaderProcessFactory createFactory(
try {
jobGraph =
- jobGraphRetriever.retrieveJobGraph(
- partialDispatcherServices.getConfiguration());
+ Preconditions.checkNotNull(
+ jobGraphRetriever.retrieveJobGraph(
+
partialDispatcherServices.getConfiguration()));
} catch (FlinkException e) {
throw new FlinkRuntimeException("Could not retrieve the
JobGraph.", e);
}
+ final JobResultStore jobResultStore =
jobPersistenceComponentFactory.createJobResultStore();
+ final Collection<JobResult> recoveredDirtyJobResults =
getDirtyJobResults(jobResultStore);
Review comment:
yeah, but I leave it like that now considering that the user is able to
modify the file-based JobResultStore... That way, we make it more robust for
such cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
