fapaul commented on a change in pull request #18428:
URL: https://github.com/apache/flink/pull/18428#discussion_r792447708
##########
File path:
flink-architecture-tests/violations/5b9eed8a-5fb6-4373-98ac-3be2a71941b8
##########
@@ -93,7 +93,6 @@ org.apache.flink.connector.file.src.util.Pool.recycler():
Returned leaf type org
org.apache.flink.connector.file.src.util.Utils.forEachRemaining(org.apache.flink.connector.file.src.reader.BulkFormat$Reader,
java.util.function.Consumer): Argument leaf type
org.apache.flink.connector.file.src.reader.BulkFormat$Reader does not satisfy:
reside outside of package 'org.apache.flink..' or annotated with @Public or
annotated with @PublicEvolving or annotated with @Deprecated
org.apache.flink.connector.jdbc.JdbcExactlyOnceOptions.builder(): Returned
leaf type
org.apache.flink.connector.jdbc.JdbcExactlyOnceOptions$JDBCExactlyOnceOptionsBuilder
does not satisfy: reside outside of package 'org.apache.flink..' or annotated
with @Public or annotated with @PublicEvolving or annotated with @Deprecated
org.apache.flink.connector.jdbc.JdbcExecutionOptions.builder(): Returned leaf
type org.apache.flink.connector.jdbc.JdbcExecutionOptions$Builder does not
satisfy: reside outside of package 'org.apache.flink..' or annotated with
@Public or annotated with @PublicEvolving or annotated with @Deprecated
-org.apache.flink.connector.jdbc.JdbcSink.exactlyOnceSink(java.lang.String,
org.apache.flink.connector.jdbc.JdbcStatementBuilder,
org.apache.flink.connector.jdbc.JdbcExecutionOptions,
org.apache.flink.connector.jdbc.JdbcExactlyOnceOptions,
org.apache.flink.util.function.SerializableSupplier): Argument leaf type
org.apache.flink.util.function.SerializableSupplier does not satisfy: reside
outside of package 'org.apache.flink..' or annotated with @Public or annotated
with @PublicEvolving or annotated with @Deprecated
Review comment:
I guess this change should have belonged to this ticket
https://issues.apache.org/jira/browse/FLINK-25570 I am not sure why the tests
did not fail before. I can make this change on a separate commit but I would
keep it on this PR.
For the other archunit changes afaict they are related to changes of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]