CrynetLogistics commented on a change in pull request #18483:
URL: https://github.com/apache/flink/pull/18483#discussion_r792468424
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSinkElementConverter.java
##########
@@ -54,7 +54,7 @@ private KinesisDataStreamsSinkElementConverter(
this.partitionKeyGenerator = partitionKeyGenerator;
}
- @Experimental
+ @Internal
Review comment:
I guess I can make the `ElementConverter` `@Internal`....
But it's still the case that @vahmed-hamdy is using some parts for public
parts and the converter is an internal tool.
```
KinesisDataStreamsSinkElementConverter.apply(java.lang.Object,
org.apache.flink.api.connector.sink.SinkWriter$Context): Argument leaf type
org.apache.flink.api.connector.sink.SinkWriter$Context does not satisfy: reside
outside of package 'org.apache.flink..' or annotated with @Public or annotated
with @PublicEvolving or annotated with @Deprecated
KinesisDataStreamsSinkElementConverter.apply(java.lang.Object,
org.apache.flink.api.connector.sink.SinkWriter$Context): Argument leaf type
org.apache.flink.api.connector.sink.SinkWriter$Context does not satisfy: reside
outside of package 'org.apache.flink..' or annotated with @Public or annotated
with @PublicEvolving or annotated with @Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
