zentol commented on a change in pull request #18434:
URL: https://github.com/apache/flink/pull/18434#discussion_r792578144
##########
File path:
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/messages/RemoteRpcInvocation.java
##########
@@ -35,13 +34,12 @@
* contains a non-serializable object, then an {@link IOException} is thrown.
*/
public class RemoteRpcInvocation implements RpcInvocation, Serializable {
Review comment:
javadocs are outdated
##########
File path:
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/MessageSerializationTest.java
##########
@@ -139,32 +139,6 @@ public void testSerializableRemoteMessageTransfer() throws
Exception {
assertThat(linkedBlockingQueue.take(), Is.<Object>is(expected));
}
- /**
- * Tests that a message which exceeds the maximum frame size is detected
and a corresponding
- * exception is thrown.
- */
- @Test(expected = IOException.class)
- public void testMaximumFramesizeRemoteMessageTransfer() throws Exception {
Review comment:
Which tests now covers the case of oversized messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
