CrynetLogistics commented on a change in pull request #18518:
URL: https://github.com/apache/flink/pull/18518#discussion_r792609714
##########
File path:
flink-connectors/flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/util/AWSDynamoDbUtil.java
##########
@@ -0,0 +1,184 @@
+/*
Review comment:
I like your current approach more, like you said, we'd not leak any ddb
sdk interfaces.
Plus, I'm not sure there is a way to pass `DynamoDbClientProvider` to the
`DynamoDbSinkWriter` without first making it a field in `DynamoDbSink`. If I'm
not wrong, I believe the `DynamoDbSink` will complain that
`DynamoDbAsyncClient` in your `DynamoDbClientProvider` is not serialisable
during runtime (it compiles ok).
I think all fields of the sink must be serialisable... so even if we wanted
to accept a customer-ready-made `DynamoDbAsyncClient`, I'm not sure there's a
good way to do it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
