dannycranmer commented on a change in pull request #18468:
URL: https://github.com/apache/flink/pull/18468#discussion_r790788442
##########
File path:
flink-connectors/flink-sql-connector-aws-kinesis-data-streams/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,47 @@
+flink-sql-connector-aws-kinesis-data-streams
+
+Copyright 2014-2021 The Apache Software Foundation
Review comment:
Should this be 2022 now?
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-data-streams/pom.xml
##########
@@ -0,0 +1,113 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-aws-kinesis-data-streams</artifactId>
+ <name>Flink : Connectors : SQL : AWS Kinesis Data Streams</name>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-aws-kinesis-data-streams</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
Looking at your shading:
```
**[INFO] --- maven-shade-plugin:3.2.4:shade (shade-flink) @
flink-sql-connector-aws-kinesis-data-streams ---
[INFO] Including
org.apache.flink:flink-connector-aws-kinesis-data-streams:jar:1.15-SNAPSHOT in
the shaded jar.
[INFO] Including org.apache.flink:flink-connector-base:jar:1.15-SNAPSHOT in
the shaded jar.
[INFO] Including org.apache.flink:flink-connector-aws-base:jar:1.15-SNAPSHOT
in the shaded jar.
[INFO] Including software.amazon.awssdk:sdk-core:jar:2.17.52 in the shaded
jar.
[INFO] Including software.amazon.awssdk:annotations:jar:2.17.52 in the
shaded jar.
[INFO] Including software.amazon.awssdk:http-client-spi:jar:2.17.52 in the
shaded jar.
[INFO] Including software.amazon.awssdk:metrics-spi:jar:2.17.52 in the
shaded jar.
[INFO] Including software.amazon.awssdk:utils:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:profiles:jar:2.17.52 in the shaded
jar.
[INFO] Including org.reactivestreams:reactive-streams:jar:1.0.3 in the
shaded jar.
[INFO] Including software.amazon.awssdk:kinesis:jar:2.17.52 in the shaded
jar.
[INFO] Including software.amazon.awssdk:aws-cbor-protocol:jar:2.17.52 in the
shaded jar.
[INFO] Including
software.amazon.awssdk:third-party-jackson-dataformat-cbor:jar:2.17.52 in the
shaded jar.
[INFO] Including software.amazon.awssdk:third-party-jackson-core:jar:2.17.52
in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-json-protocol:jar:2.17.52 in the
shaded jar.
[INFO] Including software.amazon.awssdk:json-utils:jar:2.17.52 in the shaded
jar.
[INFO] Including software.amazon.awssdk:protocol-core:jar:2.17.52 in the
shaded jar.
[INFO] Including software.amazon.awssdk:auth:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:regions:jar:2.17.52 in the shaded
jar.
[INFO] Including software.amazon.awssdk:aws-core:jar:2.17.52 in the shaded
jar.
[INFO] Including software.amazon.awssdk:apache-client:jar:2.17.52 in the
shaded jar.
[INFO] Including software.amazon.awssdk:netty-nio-client:jar:2.17.52 in the
shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.68.Final in the shaded
jar.
[INFO] Including io.netty:netty-codec-http2:jar:4.1.68.Final in the shaded
jar.
[INFO] Including io.netty:netty-codec:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.68.Final in the shaded jar.
[INFO] Including
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.68.Final in the
shaded jar.
[INFO] Including
io.netty:netty-transport-native-unix-common:jar:4.1.68.Final in the shaded jar.
[INFO] Including com.typesafe.netty:netty-reactive-streams-http:jar:2.0.5 in
the shaded jar.
[INFO] Including com.typesafe.netty:netty-reactive-streams:jar:2.0.5 in the
shaded jar.
[INFO] Including software.amazon.awssdk:sts:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-query-protocol:jar:2.17.52 in
the shaded jar.
[INFO] Including org.apache.flink:flink-table-common:jar:1.15-SNAPSHOT in
the shaded jar.
[INFO] Excluding software.amazon.eventstream:eventstream:jar:1.0.1 from the
shaded jar.
[INFO] Excluding org.apache.httpcomponents:httpclient:jar:4.5.13 from the
shaded jar.
[INFO] Excluding commons-logging:commons-logging:jar:1.1.3 from the shaded
jar.
[INFO] Excluding commons-codec:commons-codec:jar:1.15 from the shaded jar.
[INFO] Excluding org.apache.httpcomponents:httpcore:jar:4.4.14 from the
shaded jar.
[INFO] Excluding org.apache.flink:flink-core:jar:1.15-SNAPSHOT from the
shaded jar.
[INFO] Excluding org.apache.flink:flink-annotations:jar:1.15-SNAPSHOT from
the shaded jar.
[INFO] Excluding org.apache.flink:flink-metrics-core:jar:1.15-SNAPSHOT from
the shaded jar.
[INFO] Excluding org.apache.commons:commons-lang3:jar:3.3.2 from the shaded
jar.
[INFO] Excluding com.esotericsoftware.kryo:kryo:jar:2.24.0 from the shaded
jar.
[INFO] Excluding com.esotericsoftware.minlog:minlog:jar:1.2 from the shaded
jar.
[INFO] Excluding commons-collections:commons-collections:jar:3.2.2 from the
shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-guava:jar:30.1.1-jre-14.0
from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-asm-7:jar:7.1-14.0 from the
shaded jar.
[INFO] Excluding com.ibm.icu:icu4j:jar:67.1 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-force-shading:jar:14.0 from
the shaded jar.
[INFO] Excluding org.objenesis:objenesis:jar:2.1 from the shaded jar.
[INFO] Excluding org.apache.commons:commons-compress:jar:1.21 from the
shaded jar.
[INFO] No artifact matching filter io.netty:netty
```
Is this expected?
```
[INFO] Excluding org.apache.httpcomponents:httpclient:jar:4.5.13 from the
shaded jar.
```
FYI we shade for legacy connector, it might be required for ASSUME_ROLE:
```
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.13 in the
shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.14 in the shaded
jar.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
