tillrohrmann commented on a change in pull request #17485:
URL: https://github.com/apache/flink/pull/17485#discussion_r792693409
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
##########
@@ -402,6 +440,87 @@ public static ZooKeeperLeaderElectionDriverFactory
createLeaderElectionDriverFac
return new ZooKeeperLeaderElectionDriverFactory(client, path);
}
+ public static void writeLeaderInformationToZooKeeper(
+ LeaderInformation leaderInformation,
+ CuratorFramework curatorFramework,
+ BooleanSupplier hasLeadershipCheck,
+ String connectionInformationPath)
+ throws Exception {
+ final byte[] data;
+
+ if (leaderInformation.isEmpty()) {
+ data = null;
Review comment:
Do you mean a test where we write and read a
`LeaderInformation.empty()`? This sounds like a good idea. If you meant a test
where we use curator to write a `null` data, I think this not needed given the
other test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
