KarmaGYZ commented on a change in pull request #18434:
URL: https://github.com/apache/flink/pull/18434#discussion_r793223927
##########
File path:
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/MessageSerializationTest.java
##########
@@ -139,32 +139,6 @@ public void testSerializableRemoteMessageTransfer() throws
Exception {
assertThat(linkedBlockingQueue.take(), Is.<Object>is(expected));
}
- /**
- * Tests that a message which exceeds the maximum frame size is detected
and a corresponding
- * exception is thrown.
- */
- @Test(expected = IOException.class)
- public void testMaximumFramesizeRemoteMessageTransfer() throws Exception {
Review comment:
Before this PR, Flink will eagerly check the oversized messages. Now,
when there is an oversized message, the job will fail with Akka's
`AskTimeoutException` and there will be an error log from Akka which indicates
the exact size of that message. As Flink does not take the responsibility to
detect oversized messages, I think we don't need such tests anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
