imaffe commented on a change in pull request #17452:
URL: https://github.com/apache/flink/pull/17452#discussion_r793300636
##########
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSource.java
##########
@@ -97,16 +94,14 @@
* PulsarSourceBuilder}.
*/
PulsarSource(
- Configuration configuration,
+ SourceConfiguration sourceConfiguration,
Review comment:
For source related changes, I guess the changes to the source is related
to sink because we want to align the naming conventions and hierarchy , but
maybe consider putting in a separate commit ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
