Myracle commented on a change in pull request #18296:
URL: https://github.com/apache/flink/pull/18296#discussion_r793376407



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java
##########
@@ -177,6 +177,34 @@ public void testTerminationAfterJobCompletion() throws 
Exception {
         }
     }
 
+    /**
+     * Tests that in detached mode, the {@link MiniDispatcher} will not 
complete the future that
+     * signals job termination if the JobStatus is not globally terminal state.
+     */
+    @Test
+    public void testNotTerminationWithoutGloballyTerminalState() throws 
Exception {

Review comment:
       I have modified the code to test the shutDownFuture not finished.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to