tillrohrmann commented on a change in pull request #18526:
URL: https://github.com/apache/flink/pull/18526#discussion_r793424727



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotAllocationContext.java
##########
@@ -44,9 +45,9 @@
      * Returns prior allocation id for an execution vertex.
      *
      * @param executionVertexId id of the execution vertex
-     * @return prior allocation id for the given execution vertex
+     * @return prior allocation id for the given execution vertex if it exists
      */
-    AllocationID getPriorAllocationId(ExecutionVertexID executionVertexId);
+    Optional<AllocationID> getPriorAllocationId(ExecutionVertexID 
executionVertexId);

Review comment:
       Sounds good to me. Will change the method names accordingly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to