zentol commented on a change in pull request #18443:
URL: https://github.com/apache/flink/pull/18443#discussion_r793708917



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -511,9 +511,8 @@ public void deploy() throws JobException {
         }
 
         // make sure exactly one deployment call happens from the correct state
-        // note: the transition from CREATED to DEPLOYING is for testing 
purposes only
         ExecutionState previous = this.state;
-        if (previous == SCHEDULED || previous == CREATED) {

Review comment:
       I had similar thought. It's not possible in the ExecutionState (because 
of circular dependencies between RUNNING and RESTARTING), but we could 
certainly introduce a separate ExecutionStateTransition enum that captures all 
of that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to