akalash commented on a change in pull request #18482:
URL: https://github.com/apache/flink/pull/18482#discussion_r793811815
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointOptionsTest.java
##########
@@ -55,9 +56,17 @@ public void testSavepoint() throws Exception {
final byte[] locationBytes = new byte[rnd.nextInt(41) + 1];
rnd.nextBytes(locationBytes);
+ final SnapshotType[] snapshotTypes = {
+ CHECKPOINT,
+ FULL_CHECKPOINT,
+ SavepointType.savepoint(SavepointFormatType.CANONICAL),
+ SavepointType.suspend(SavepointFormatType.CANONICAL),
+ SavepointType.terminate(SavepointFormatType.CANONICAL)
+ };
Review comment:
I would say it will be nice to test everything but of course, it is not
so crucial. Perhaps, we should test the serialization of SavepointType
separately using the constructor so if somebody adds a new parameter they will
be forced to change the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
